#606 √ resolved
Vitaliy Geraymovych

[PATCH] File.join with no arguments should return empty string

Reported by Vitaliy Geraymovych | June 11th, 2008 @ 11:42 AM | in 1.0 preview

Existing spec fails when File.join is called without arguments.

~/work/rubinius $ bin/mspec spec/frozen/1.8/core/file/join_spec.rb E..........

1) File.join returns an empty string when given no arguments ERROR NoMethodError: No method 'empty?' on an instance of NilClass.

Kernel(NilClass)#empty? (method_missing_cv) at kernel/core/kernel.rb:647

patch checks if args array is empty.

After patch is applied:

~/work/rubinius $ bin/mspec spec/frozen/1.8/core/file/join_spec.rb ...........

Finished in 0.037948 seconds

1 file, 11 examples, 39 expectations, 0 failures, 0 errors

Comments and changes to this ticket

  • Federico Builes

    Federico Builes June 11th, 2008 @ 08:04 PM

    • → State changed from “new” to “resolved”

    This has been applied in add00ef, thanks!

    You can get a commit bit by uploading your public key to pastie and passing that link along with that commit ref to evan on IRC.

Please Login or create a free account to add a new comment.

You can update this ticket by sending an email to from your email client. (help)

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

People watching this ticket

Tags