[PATCH] spec files for cgi.rb
Reported by kwatch | March 31st, 2008 @ 01:03 AM | in 1.0 preview
I'm creating spec files for cgi.rb.
Currently, CGI.new raises error due to ticket#454.
So I post spec files which doesn't need CGI object.
- spec files for CGI::escape() and CGI::unescape()
I'll post patches in this ticket if I create new spec files,
so please leave this ticket opened.
Comments and changes to this ticket
-
-
-
Charles Comstock March 31st, 2008 @ 01:05 PM
- → State changed from “new” to “open”
could you please rebase these patches after doing bin/mkspec -b spec/ruby/1.8/library -r lib/cgi.rb -c CGI
That will generate all the initial spec files and then we can apply your patches to those files.
-
kwatch March 31st, 2008 @ 04:25 PM
That command generates many spec files which contains no tests.
Do you mean that I should add not only spec files which contain tests but also those which doesn't contain any test?
-
Charles Comstock March 31st, 2008 @ 07:31 PM
Each file reminds us which functions need testing, and ensure tests are in a similar format. Generate the files, re-apply your patches to those files, and upload your patches again.
-
kwatch April 4th, 2008 @ 09:10 PM
I re-created patches.
- Please ignore previous patches.
- Add spec files for cgir.rb
- Spec files for CGI::escape() and CGI::unescape()
- Spec files for CGI::escapeHTML() and CGI::unescapeHTML()
- Spec files for CGI::rfc1123_date()
Could you review these patches?
-
kwatch April 4th, 2008 @ 09:10 PM
- no changes were found...
-
kwatch April 4th, 2008 @ 09:10 PM
- no changes were found...
-
kwatch April 4th, 2008 @ 09:10 PM
- no changes were found...
-
Eero Saynatkari April 4th, 2008 @ 11:12 PM
- → Assigned user changed from “” to “Eero Saynatkari”
-
Eero Saynatkari April 5th, 2008 @ 12:29 AM
- → State changed from “open” to “resolved”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
