#352 √ resolved
seydar

[BUG] IPAddr specs used improper IPv6 notation

Reported by seydar | February 23rd, 2008 @ 12:15 PM | in 1.0 preview

Capital letters aren't allowed (I think)

BUT there is a fix:

Comments and changes to this ticket

  • seydar

    seydar February 23rd, 2008 @ 12:15 PM

    the fix is what I attached

  • Dirkjan Bussink

    Dirkjan Bussink February 24th, 2008 @ 11:32 AM

      • → State changed from “new” to “open”

    The problem with these changes is that you changed the spec, not the implementation. The specs work MRI (MatzRuby), so they need to work on Rubinius too.

    Besides this, there seems to be a lot of whitespace changes. Make sure your editor is set to a tab size of 2 and uses soft tabs (so it creates spaces, not actual tabs).

  • Ryan Davis

    Ryan Davis February 29th, 2008 @ 07:17 PM

      • → Assigned user changed from “” to “Brian Ford”
  • Dirkjan Bussink

    Dirkjan Bussink March 9th, 2008 @ 06:57 PM

      • → State changed from “open” to “resolved”

    I've fixed all the specs for IPAddr. Nothing had to be changed in the implementation itself, all failures where due to problems elsewhere.

  • seydar

    seydar March 9th, 2008 @ 09:43 PM

    Hmm I though I committed a change that fixed it (downcased the addr), but you probably wrote a better patch.

  • Dirkjan Bussink

    Dirkjan Bussink March 10th, 2008 @ 03:05 AM

    Well, the problem was that there was a bug in the regexp library (oniguruma), which is fixed in the latest version. When I pulled that version in, this problem was also fixed.

Please Login or create a free account to add a new comment.

You can update this ticket by sending an email to from your email client. (help)

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

People watching this ticket

Tags