rubinius

Comments and changes to this ticket

• 

  Justin Bradford January 15th, 2008 @ 08:32 PM

  However, this fails for Dir based objects -- we need some other way to check the validity of a file descriptor. Perhaps a fstat?

• 

  Eero Saynatkari January 15th, 2008 @ 08:42 PM

  • → State changed from “new” to “open”
  • → Assigned user changed from “” to “Eero Saynatkari”

  Will commit as soon as I have the chance to review and test if no-one gets to it.

• 

  Justin Bradford January 15th, 2008 @ 09:57 PM

  The current patch works correctly for files, but fails for directories. The patch in its current form should not be committed, but we do need a more robust method of checking validity of descriptors. I think we might need a new primitive. A fstat call should work for both, but I haven't tested it yet.

• 

  Brian Ford January 20th, 2008 @ 12:50 PM

  • → Title changed from “initialization of IO should check for a bad file descriptor” to “[PATCH] initialization of IO should check for a bad file descriptor”
• 

  Eero Saynatkari January 30th, 2008 @ 06:08 PM

  • → State changed from “open” to “resolved”

  fcntl() based fix for this committed as ed99ebe2. Thanks for pointing this out!