[PATCH] marshal primitive naming conflicts
Reported by Justin Bradford | January 16th, 2008 @ 04:24 AM | in 1.0
Access to the non-standard marshal_object and unmarshal_object primitives conflicted with functions on the standard Marshal class (eg. dump and load).
This patch simply renames the primitive access functions to dump_object and load_object, but these primitives do not appear to be used anywhere in the code. The compiler only uses to the to/from_file variants.
Comments and changes to this ticket
-
Eero Saynatkari January 16th, 2008 @ 05:44 AM
- → State changed from “new” to “open”
We should probably try to create a completely separate naming for the rbc marshal format for simplicity.
-
Justin Bradford January 16th, 2008 @ 07:31 AM
I agree. No code appears to use the marshal_object and unmarshal_object primitives. Further, only the compiler uses marshal_to_file and unmarshal_from_file primitives.
If the compiler code must rely on primitives, I suggest we eliminate the marshal_object and unmarshal_object primitives, and rename the file based primitives to compiler_marshal and compiler_unmarshal. Further, we should only expose those primitives via the non-standard Compiler class (as marshal/unmarshal or dump/load), moving them out of the Marshal class completely.
-
Brian Ford January 20th, 2008 @ 09:49 PM
- → Title changed from “marshal primitive naming conflicts” to “[PATCH] marshal primitive naming conflicts”
-
Ryan Davis February 29th, 2008 @ 11:44 PM
- → Assigned user changed from “” to “Evan Phoenix”
- → Milestone changed from “1.0 preview” to “1.0”
-
Ryan Davis March 18th, 2008 @ 12:15 AM
- → Assigned user changed from “Evan Phoenix” to “Ryan Davis”
-
Ryan Davis July 10th, 2008 @ 10:21 PM
- → Assigned user changed from “Ryan Davis” to “Evan Phoenix”
- → Tag changed from “” to “lib marshal patch primitive rbc”
hrm... I assigned to evan for official weigh in and then took it back... we must have talked about it over irc or something cause I have no idea what the verdict was... assigning back so we can get it recorded here.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Evan Phoenix