[patch] vm builtin_sendsite.cpp using wrong source for as<Executable>
Reported by Juha Pohjalainen | July 17th, 2008 @ 06:02 PM | in 1.0 preview
This bug is shown at test_task.hpp in test_locate_method_on_private_private_send test. It fails already.
Problem can be found from builtin_sendsite.cpp method HierarchyResolver::resolve -- around line 75 (and maybe 98 is wrong also) there is code:
msg.method = as(entry);
that cast fails with unknown type (it is a MethodVisibility?).
Partial fix could be:
msg.method = as(vis ? vis->method : entry);
It might not be correct one, but you should get the idea.
Is this enough info, or is something else needed?
Comments and changes to this ticket
-
Juha Pohjalainen July 18th, 2008 @ 01:59 AM
Second try with code (formatting ate my angle brackets and Executable previously). Was:
msg.method = as(entry);
and could be:
msg.method = as(vis ? vis->method : entry);
-
Juha Pohjalainen July 18th, 2008 @ 02:02 AM
Crap! Third try.
Was:
msg.method = as<Executable>(entry);
Could be:
msg.method = as<Executable>(vis ? vis->method : entry);
-
Juha Pohjalainen July 18th, 2008 @ 07:44 AM
- → Title changed from “vm builtin_sendsite.cpp using wrong source for as<Executable>” to “[patch] vm builtin_sendsite.cpp using wrong source for as<Executable>”
Adding sample patch.
-
Juha Pohjalainen July 18th, 2008 @ 12:47 PM
- → Tag changed from “bug compiler” to “bug compiler patch”
Changed line 98 to one without conditionals. As chatted with dbussink at #rubinius.
-
-
Dirkjan Bussink July 18th, 2008 @ 02:09 PM
- → State changed from “new” to “resolved”
Fixed in commit ff1fc4e3bcde02cd905d039e3b22bedf5a7935c4
You can contact Evan to get commit access.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Evan Phoenix